Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: getting rid of some things #1782

Closed
2 of 4 tasks
ghost opened this issue Apr 4, 2019 · 3 comments
Closed
2 of 4 tasks

Suggestion: getting rid of some things #1782

ghost opened this issue Apr 4, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Apr 4, 2019

We currently carry around a few things which I think would be worth removing soon:

  • Python 3 CrystaX support: it causes lots of conditionals and special paths, and what does it offer at this point except a worse, outdated python version?
  • python2legacy recipe: I understand it allows lowering the API level a little, but only for Python 2 which we want to fade out anyway, so is it really worth keeping around?
  • pygame: it's in bad shape, and again adds so many special switches. and there's pygame-sdl2 now I believe, maybe that would even run easily in our SDL2 bootstrap?
  • launcher/--launcher: shouldn't this rather be a separate kivy standalone app? this complicates the bootstrapping unnecessarily and there's weird whatever-licensed renpy code in the source tree for it. does it even run at this point?

I'm just leaving this list here for discussion

@ghost
Copy link
Author

ghost commented Apr 4, 2019

(I personally want to look into a launcher/--launcher removal pull request very soon. I might also look into some of the others if you want me to, unless someone else wants to do it of course. For pygame we have a pull request but it seems to have gotten a bit stale)

@inclement
Copy link
Member

My view is:

  • python3crystax: Let's go ahead and remove it, but first at least announce it a bit in advance to try and clearly document the change. I don't want to be too hasty just because this was quite widely used for a couple of years.
  • python2legacy: This can go as soon as you like, as far as I'm concerned.
  • pygame: This can go too, I'll try to update my old PR or if someone else wants to make one then that's fine too.
  • launcher: I'd rather not remove this right now unless it's actively getting in the way, unless the replacement @tito made is fully working. I'm pretty sure it should still run at the moment.

@Julian-O
Copy link
Contributor

Rumour is that both launchers are out of action and unlikely to be fixed any time soon, so launcher code could also be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants