Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename misguided shadowing --blacklist to --blacklist-requirements #1689

Merged
merged 1 commit into from Feb 7, 2019
Merged

Rename misguided shadowing --blacklist to --blacklist-requirements #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/source/buildoptions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,18 +245,18 @@ options (this list may not be exhaustive):
- ``--resource``: A key=value pair to add in the string.xml resource file.


Blacklist (APK size optimization)
---------------------------------
Requirements blacklist (APK size optimization)
----------------------------------------------

To optimize the size of the `.apk` file that p4a builds for you,
you can **blacklist** certain core components. Per default, p4a
will add python *with batteries included* as would be expected on
desktop, including openssl, sqlite3 and other components you may
not use.

To blacklist an item, specify the ``--blacklist`` option::
To blacklist an item, specify the ``--blacklist-requirements`` option::

p4a apk ... --blacklist=sqlite3
p4a apk ... --blacklist-requirements=sqlite3

At the moment, the following core components can be blacklisted
(if you don't want to use them) to decrease APK size:
Expand Down
6 changes: 3 additions & 3 deletions pythonforandroid/toolchain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def build_dist_from_args(ctx, dist, args):
"""Parses out any bootstrap related arguments, and uses them to build
a dist."""
bs = Bootstrap.get_bootstrap(args.bootstrap, ctx)
blacklist = getattr(args, "blacklist", "").split(",")
blacklist = getattr(args, "blacklist_requirements", "").split(",")
if len(blacklist) == 1 and blacklist[0] == "":
blacklist = []
build_order, python_modules, bs = (
Expand Down Expand Up @@ -310,10 +310,10 @@ def __init__(self):
default='')

generic_parser.add_argument(
'--blacklist',
'--blacklist-requirements',
help=('Blacklist an internal recipe from use. Allows '
'disabling Python 3 core modules to save size'),
dest="blacklist",
dest="blacklist_requirements",
default='')

generic_parser.add_argument(
Expand Down