Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename misguided shadowing --blacklist to --blacklist-requirements #1689

Merged
merged 1 commit into from Feb 7, 2019
Merged

Rename misguided shadowing --blacklist to --blacklist-requirements #1689

merged 1 commit into from Feb 7, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 7, 2019 •
edited by ghost
Loading

Rename misguided shadowing --blacklist to --blacklist-requirements.

Merging this only makes sense if you want to keep the blacklist functionality of course, see discussion in #1683

@ghost ghost mentioned this pull request Feb 7, 2019
Merged
@ghost ghost changed the title [WIP] Rename misguided shadowing --blacklist to --blacklist-requirements Rename misguided shadowing --blacklist to --blacklist-requirements Feb 7, 2019
inclement
inclement approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, best to merge to fix --blacklist regardless of what we do in the end.

@inclement inclement merged commit e86f346 into kivy:master Feb 7, 2019
@ghost ghost deleted the rename_blacklist_opt branch February 8, 2019 03:58
@opacam opacam mentioned this pull request Feb 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inclement