fix: OverKeyboardView
compatibility with RN 0.72
#658
Merged
+19
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added
RootViewCompat
interface to prevent build issues on RN < 0.72.💡 Motivation and Context
Prior to RN 0.73
RootView
markedonChildStartedNativeGesture(ev: MotionEvent?)
as deprecated, but without default implementation, so if you useRootView
you had to override two methods:onChildStartedNativeGesture(ev: MotionEvent?)
override fun onChildStartedNativeGesture(childView: View, ev: MotionEvent)
;To fix this problem I decided to introduce common
RootViewCompat
interface that will have a stub for deprecated method.The reason why I moved it to separate file was mostly following SOLID principles - potentially this interface can be re-used in other parts of application, and I can not implement method directly in
OverKeyboardRootViewGroup
because I'll exceed maximum methods amount (11+).Closes #657
📢 Changelog
Android
RootViewCompat
;RootViewCompat
instead ofRootView
.🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist