Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix:
OverKeyboardView
compatibility with RN 0.72 (#658)
## 📜 Description Added `RootViewCompat` interface to prevent build issues on RN < 0.72. ## 💡 Motivation and Context Prior to RN 0.73 `RootView` marked `onChildStartedNativeGesture(ev: MotionEvent?)` as deprecated, but without default implementation, so if you use `RootView` you had to override two methods: - `onChildStartedNativeGesture(ev: MotionEvent?)` - `override fun onChildStartedNativeGesture(childView: View, ev: MotionEvent)`; To fix this problem I decided to introduce common `RootViewCompat` interface that will have a stub for deprecated method. The reason why I moved it to separate file was mostly following SOLID principles - potentially this interface can be re-used in other parts of application, and I can not implement method directly in `OverKeyboardRootViewGroup` because I'll exceed maximum methods amount (11+). Closes #657 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### Android - added `RootViewCompat`; - use `RootViewCompat` instead of `RootView`. ## 🤔 How Has This Been Tested? Tested on CI. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
- Loading branch information