Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Banner: set height explicitly to preserve scroll state in safari #3804

Merged
merged 13 commits into from
Feb 27, 2025

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Feb 24, 2025

Which issue does this PR close?

This PR closes #3810

What is the new behavior?

See issue for background.
Scroll state is now preserved because the image-banner has explicit height set.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot had a problem deploying to pr-image-banner-missing-scroll-height February 24, 2025 13:18 Failure
@github-actions github-actions bot temporarily deployed to pr-image-banner-missing-scroll-height February 26, 2025 13:15 Inactive
@github-actions github-actions bot temporarily deployed to pr-image-banner-missing-scroll-height February 26, 2025 13:16 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the title Bug/image banner missing scroll height Image Banner: set height explicitly to preserve scroll state of page in safari Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard changed the title Image Banner: set height explicitly to preserve scroll state of page in safari Image Banner: set height explicitly to preserve scroll state in safari Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard marked this pull request as ready for review February 26, 2025 14:43
RasmusTraeholt
RasmusTraeholt previously approved these changes Feb 27, 2025
@RasmusKjeldgaard RasmusKjeldgaard merged commit 24ad7a0 into develop Feb 27, 2025
9 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the bug/image-banner-missing-scroll-height branch February 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Scroll state of kirby-page not preserved when using image-banner in Safari
2 participants