Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scroll state of kirby-page not preserved when using image-banner in Safari #3810

Closed
1 of 9 tasks
RasmusKjeldgaard opened this issue Feb 26, 2025 · 0 comments · Fixed by #3804
Closed
1 of 9 tasks
Assignees
Labels

Comments

@RasmusKjeldgaard
Copy link
Collaborator

RasmusKjeldgaard commented Feb 26, 2025

Describe the bug

In Safari, when navigating back to a page with akirby-x-image-banner, scroll state is not preserved correctly. Even though we use inline-size for the container-query in image-banner, the height does not seem to be correctly calculated for the element when returning back to a page in the stack of an ion-router-outlet. I am unsure if this is a safari + containment issue or if it is a ion-router-outlet + safari + containment issue 🤷

Describe how to reproduce the bug

  1. Go to https://stackblitz.com/edit/stackblitz-starters-3jbke7cs in safari. See * below if this does not work.
  2. Scroll to the bottom of the page, click 'Go to Page Two', then press the back-button of the new page.
  3. Observe that 'Page One' is scrolled all the way to the top. In chromium-browsers, previous scroll state is preserved and you land at the bottom of the page instead.

* Safari and stackblitz does not always play nice. If the example never loads, do the following instead:

  1. Click on the small "cloud + arrow down" icon to download the example. This is currently needed because stackblitz preview and safari does not play nice.
  2. run npm i && npm start locally
  3. go to localhost in Safari

Which Kirby version was used?

Kirby Extensions v1.3.0

Add any screenshots

Heres a video showcasing the issue:

safari-missing-scroll-state.mov

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild 👶🏻 New For new issues before prioritisation and refinement labels Feb 26, 2025
@github-project-automation github-project-automation bot moved this to 💌 Inbox in Kirby Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard self-assigned this Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard removed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 💌 Inbox to 🔎 Review Pending in Kirby Feb 26, 2025
@RasmusKjeldgaard RasmusKjeldgaard moved this from 🔎 Review Pending to 👀 Review In Progress in Kirby Feb 26, 2025
@github-project-automation github-project-automation bot moved this from 👀 Review In Progress to ✅ Done in Kirby Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants