You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Safari, when navigating back to a page with akirby-x-image-banner, scroll state is not preserved correctly. Even though we use inline-size for the container-query in image-banner, the height does not seem to be correctly calculated for the element when returning back to a page in the stack of an ion-router-outlet. I am unsure if this is a safari + containment issue or if it is a ion-router-outlet + safari + containment issue 🤷
Scroll to the bottom of the page, click 'Go to Page Two', then press the back-button of the new page.
Observe that 'Page One' is scrolled all the way to the top. In chromium-browsers, previous scroll state is preserved and you land at the bottom of the page instead.
* Safari and stackblitz does not always play nice. If the example never loads, do the following instead:
Click on the small "cloud + arrow down" icon to download the example. This is currently needed because stackblitz preview and safari does not play nice.
run npm i && npm start locally
go to localhost in Safari
Which Kirby version was used?
Kirby Extensions v1.3.0
Add any screenshots
Heres a video showcasing the issue:
safari-missing-scroll-state.mov
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Verification
To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.
Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done.
Implementation
The contributor who wants to implement this issue should:
RasmusKjeldgaard
removed
NOT Prioritized
Issue not yet prioritized and added to a Milestone
👶🏻 New
For new issues before prioritisation and refinement
NOT Verified
Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
labels
Feb 26, 2025
Describe the bug
In Safari, when navigating back to a page with a
kirby-x-image-banner
, scroll state is not preserved correctly. Even though we useinline-size
for the container-query inimage-banner
, the height does not seem to be correctly calculated for the element when returning back to a page in the stack of anion-router-outlet
. I am unsure if this is a safari + containment issue or if it is a ion-router-outlet + safari + containment issue 🤷Describe how to reproduce the bug
* Safari and stackblitz does not always play nice. If the example never loads, do the following instead:
npm i && npm start
locallyWhich Kirby version was used?
Kirby Extensions v1.3.0
Add any screenshots
Heres a video showcasing the issue:
safari-missing-scroll-state.mov
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Verification
To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.
NOT verified
label has been removed by a member of team Kirby; do not proceed until this is done.Implementation
The contributor who wants to implement this issue should:
Review
Once the issue has been implemented and is ready for review:
The text was updated successfully, but these errors were encountered: