Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts: New heading style h4 #3333

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

AgreSanGit
Copy link
Contributor

Which issue does this PR close?

This PR closes #3332

What is the new behavior?

Added new heading style for "H4". Showcase for "H4 - section header" added in cookbook under Fonts.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@AgreSanGit AgreSanGit added the feature Add this PR to the changelog as a feature label Jan 12, 2024
@github-actions github-actions bot temporarily deployed to pr-3332-new-heading-style-h4 January 12, 2024 14:17 Inactive
@AgreSanGit AgreSanGit marked this pull request as ready for review January 15, 2024 12:07
@AgreSanGit AgreSanGit requested a review from jkaltoft as a code owner January 15, 2024 12:07
@AgreSanGit AgreSanGit self-assigned this Jan 15, 2024
@RasmusKjeldgaard RasmusKjeldgaard merged commit 69b5010 into develop Jan 15, 2024
5 checks passed
@RasmusKjeldgaard RasmusKjeldgaard deleted the enhancement/3332-new-heading-style-h4 branch January 15, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Enhancement] New heading style - H4
2 participants