Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] New heading style - H4 #3332

Closed
1 of 11 tasks
henrikvoetmand opened this issue Jan 12, 2024 · 0 comments · Fixed by #3333
Closed
1 of 11 tasks

[Enhancement] New heading style - H4 #3332

henrikvoetmand opened this issue Jan 12, 2024 · 0 comments · Fixed by #3333
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed

Comments

@henrikvoetmand
Copy link
Collaborator

Describe the enhancement

In the design library (Sketch) we have the possibility to make a Section header in font size 16 - bold.
To align and support this in Kirby code, we could define a new heading size "H4" with font size 16 - bold.

Describe the solution you'd like

Define new text style "H4"

font-size: font-size("n");
font-weight: font-weight("bold");
CLASS: h4 or kirby-text-medium

Add this new text style to the "Fonts" page on the Cookbook

05 P

https://cookbook.kirby.design/#/home/showcase/fonts

Have you considered any alternatives?

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant