Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply focus ring to the segmented control only when using tab navigation #2703

Merged

Conversation

mark-drastrup
Copy link
Contributor

Which issue does this PR close?

This PR closes #2556

What is the new behavior?

The segmented control only get a focus ring when using tab navigation, and not on mouse click.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@mark-drastrup mark-drastrup added the feature Add this PR to the changelog as a feature label Dec 27, 2022
@mark-drastrup mark-drastrup merged commit 4eadb16 into develop Dec 28, 2022
@mark-drastrup mark-drastrup deleted the enhancement/2556-segmented-control-focus-state branch December 28, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add this PR to the changelog as a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Segmented control - focus state
2 participants