Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Segmented control - focus state #2556

Closed
1 of 11 tasks
henrikvoetmand opened this issue Oct 20, 2022 · 0 comments · Fixed by #2703
Closed
1 of 11 tasks

[Enhancement] Segmented control - focus state #2556

henrikvoetmand opened this issue Oct 20, 2022 · 0 comments · Fixed by #2703
Assignees
Labels
component:Segmented Control enhancement New feature or request good first issue Good for newcomers NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Milestone

Comments

@henrikvoetmand
Copy link
Collaborator

Describe the enhancement

Today a Segmented control has a visible focus state on mouse click - both in normal and in chip mode.
Segmented controls should behave like buttons in regards to focus.

Describe the solution you'd like

Remove visible focus state (blue outline) on segmented control on mouse click.
Focus state should remain as is, when keyboard navigation is used.

Have you considered any alternatives?

Are there any additional context?

Skærmbillede 2022-10-20 kl  12 13 09


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Refinement

  • Request that the issue is UX refined; do not proceed until this is done.
  • Request that the issue is tech refined; do not proceed until this is done.

Implementation

The contributor who wants to implement this issue should:

  • Make sure you have read: "Before you get coding".
  • Signal to others you are working on the issue by assigning yourself.
  • Create a branch from the develop branch following our branch naming convention.
  • Publish a WIP implementation to Github as a draft PR and ask for feedback.
  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Update the cookbook with examples and showcases.

Review

Once the issue has been implemented and is ready for review:

  • Do a self-review.
  • Create a pull-request. If you created a draft PR during implementation you can just mark that as "ready for review".
@henrikvoetmand henrikvoetmand added enhancement New feature or request component:Segmented Control NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Oct 20, 2022
@alxzak alxzak added this to Kirby Nov 14, 2022
@alxzak alxzak removed the 👶🏻 New For new issues before prioritisation and refinement label Nov 14, 2022
@alxzak alxzak added this to the Desktop ready milestone Nov 14, 2022
@alxzak alxzak added the good first issue Good for newcomers label Dec 15, 2022
@mark-drastrup mark-drastrup self-assigned this Dec 27, 2022
@mark-drastrup mark-drastrup moved this to 🚀 In Progress in Kirby Dec 27, 2022
@mark-drastrup mark-drastrup moved this from 🚀 In Progress to 🔎 Review pending in Kirby Dec 27, 2022
@github-project-automation github-project-automation bot moved this from 🔎 Review pending to ✅ Done in Kirby Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Segmented Control enhancement New feature or request good first issue Good for newcomers NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants