Release version 5.4 #2287
Merged
Release version 5.4 #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the mess TBC...
Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.7. - [Release notes](https://github.com/mde/ejs/releases) - [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md) - [Commits](mde/ejs@v3.1.6...v3.1.7) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 🐛 Only remove popover element if it is showing * ♻️ Refactor hide() to ensure willHide is fired * 🔥 Remove backdrop click listener The event listener was not called because dropdowns onBlur event was always fired first, closing the dropdown including the popover component. In fact it was only called when clicking inside the dropdown because onBlur is not fired then - and thus it is useless at this point. Components using popover (dropdown only right now) should take care of calling hide() at the appropriate time themselves, e.g. in onBlur. * 🔥 Remove redundant isShowing check
* 🐛 Only prevent event (e.g. scroll) outside popover * ♻️ Rename preventEvent callback for clarity * ♻️ Make callback static This is to avoid future problems if 'this' is referred within the callback down the line.
Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
…module 💄 Add missing import statement
…ol/disable-change-on-swipe segmented-control - disable change on swipe attribute
Update package version to 5.4.0
jkaltoft
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Bugfixes
dropdown - experimental popover feature: Fix popovers hide() being called twice (#2195)
dropdown - experimental popover feature: Only prevent touchevent outside popover (#2205)
Features
segmented-control - add new option to disable change on swipe (#2237)