Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experiment] Reduce git history clutter #2201

Merged
merged 14 commits into from
Apr 28, 2022

Conversation

jkaltoft
Copy link
Collaborator

Which issue does this PR close?

This PR closes # (insert issue number here)

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to stable via automerge.

MadsBuchmann and others added 12 commits March 17, 2022 12:43
…ckground of the card component (#2047)

* ✨ Make it possible to set & control card bg image

* ✨ Add 'backgroundImageUrl' input property to card

* 📝 Document background-image related API

* 📝 Reword table text & remove type column

* 📝 Add card with background image examples

* 🚚 Move all card examples to a shared module

* ✅ Add tests for backgroundImageUrl

* 🖊️ Uppercase CSS in documentation

Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk>

* 📝 Expand documentation on card background image

I've attempted expanding the documentation such that it explains the pros and cons of each method.

* 📝 Modify css background example to use media queries

Co-authored-by: Jesper Kaltoft Vind <git@jesperkaltoft.dk>
* Reintroduce TimeScale for ChartJS

With stock charts we need Time Cartesian Axis for
comparison of securities.

When using time as X scale type we need a way providing
zero labels (an empty array), since these are autogenerated
by TimeScale. In chart-js.service the
method labelsToApply needs a way of returning []

* ✨ Allow an empty array to disable labels

* 🔥 Remove log statements

* ✨ Make it possible to bypass default labels for stock

Co-authored-by: Mads Buchmann Frederiksen <mbf@prochimp.dk>
With setTimeout we can avoid ResizeObserver loop exceeded
warnings. These are hidden by browsers, but can be picked up
by frontend error logging services.

It most likely happens because the ResizeObserver observes repeated
size changes before the original scaleHeader callback has finished.
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.3 to 1.5.10.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.5.3...1.5.10)

---
updated-dependencies:
- dependency-name: url-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot temporarily deployed to pr-reduce-git-history-clutter April 27, 2022 20:29 Inactive
@jkaltoft jkaltoft changed the base branch from main to main-fake April 27, 2022 20:40
@jkaltoft jkaltoft changed the base branch from main-fake to main April 27, 2022 20:50
@RasmusKjeldgaard RasmusKjeldgaard self-requested a review April 28, 2022 07:39
@jkaltoft jkaltoft merged commit 440ca6e into main Apr 28, 2022
@jkaltoft jkaltoft deleted the experiment/reduce-git-history-clutter branch April 28, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants