Deprecated attention-level 4 on kirby-button #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 17, 2021 13:42
…tton-attention-levels
RasmusKjeldgaard
requested changes
Jan 19, 2022
apps/cookbook/src/app/examples/button-example/button-example.component.scss
Outdated
Show resolved
Hide resolved
apps/cookbook/src/app/showcase/button-showcase/button-showcase.component.html
Show resolved
Hide resolved
libs/designsystem/src/lib/components/button/button.component.integration.spec.ts
Show resolved
Hide resolved
libs/designsystem/src/lib/components/button/button.component.ts
Outdated
Show resolved
Hide resolved
2c68ad4 to
1c4479d
Compare
1c4479d to
4437d27
Compare
|
Some quick thoughts, that are not related to code:
|
libs/designsystem/src/lib/components/button/button.component.ts
Outdated
Show resolved
Hide resolved
02e13c2 to
5411956
Compare
…tton-attention-levels
|
|
The latest changes has been merged with relationsbanken and all corrections requested by @henrikvoetmand has been verified in this context - looks good 😊 |
13 tasks
RasmusKjeldgaard
approved these changes
Jan 26, 2022
jkaltoft
pushed a commit
that referenced
this pull request
Feb 4, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
RasmusKjeldgaard
pushed a commit
that referenced
this pull request
Feb 10, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Feb 14, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Mar 14, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
jkaltoft
pushed a commit
that referenced
this pull request
Mar 17, 2022
* Change name of kirby-button _disableAttentionLevel parameter to noDecoration * Change styling of attentionlevel2 and update button examples * Add styling of page header button * Change button attention level test * Change kirby-page-action button to attention level 3 * Add kirby-dropdown styling for attention-level 2 * Change page action button test to comply with UX change * Add missing styling on no-decoration * Remove none from button theme selector * Change attention-level-4 deprecation warning message on kirby-button * Change after Inspection * Change deprecation text Co-authored-by: Michael Troelsen <mxt@bankdata.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR closes #1512
What is the new behavior?
Does this PR introduce a breaking change?
In order to clarify and simplify the design of the kirby-button attention-levels it has been revised as follows.
The attention-level 4 has been deprecated on kirby-button and the continued usage of this level will result in a console deprecation warning message and the button will be rendered as attention-level 3.
Up until now kirby-button with attention-level 4 has primarily been used for transparent icon-only buttons. The continued need for this specific kind of buttons has been recognized and is now available through a new 'noDecoration' parameter of kirby-button.
Furthermore the design of kirby-button on all light backgrounds is now identical to the their former presence on a 'white' kirby-card background. The biggest visual change will be on kirby-button's with attention-level 2 on a 'light' kirby-card which will have their background-color change from 'white' to a 'black'.
When migrating change attention-level 2 to attention-level 3 on all kirby-buttons which aren't black by design. Also replace all attention-level 4 usage on icon-only kirby-buttons with the no-decoration parameter ([noDecoration]="true").
Checklist:
The following tasks should be carried out in sequence in order to follow the process of contributing correctly.
Reminders
Review
When the pull request has been approved it will be automatically merged to master via automerge.