Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Button attention levels #1512

Closed
10 of 13 tasks
Tracked by #2010 ...
henrikvoetmand opened this issue Apr 27, 2021 · 3 comments · Fixed by #1993
Closed
10 of 13 tasks
Tracked by #2010 ...

[Enhancement] Button attention levels #1512

henrikvoetmand opened this issue Apr 27, 2021 · 3 comments · Fixed by #1993
Assignees
Labels
component:Button Desktop components Only for issues regarding the desktop component epic enhancement New feature or request 🟢 Ready for release Web

Comments

@henrikvoetmand
Copy link
Collaborator

henrikvoetmand commented Apr 27, 2021

Please add a short description of your enhancement request
We want to simplify the use of button attention levels.

Describe the solution you'd like

  • Reduce the amount of attention levels from 4 to 3.
  • Make the levels visual identical for "light" background (on canvas) and "white" background (on card).
  • Simplify the Cookbook-button page (Remove "Destructive button section and Remove "Toggle button section)

Describe alternatives you've considered
Leave the attentions levels As-Is - hard to use and understand.

Additional context

Btn-Issue-image

Tasks

Kick Off:

  • Ensure the enhancement is UX refined and aligned with UX
    The component and/or enhancement should be published and available in the Kirby Styleguide on Zeplin
  • Ensure the enhancement has been Tech refined with @kirbydesign/kirby-guild and this issue is updated with a clear implementation description
    This issue should be in the Ready to do column of the Kirby kan-ban board before starting implementation)
  • Assign yourself to this issue and move it to the In progress column of the Kirby kan-ban board

Code:

  • Create Feature Branch from master branch
  • Create a draft implementation and push to Github
  • Ask a member of @kirbydesign/kirby-guild for a WIP review by creating a draft Pull Request
  • Implement unit tests
  • Update Cookbook Examples and Showcase, i.e. see Radio
    Also remember to add any relevant new API documentation

Review:

  • UX review:
    • Ensure implementation is correct in relation to the UX design and the Kirby Styleguide on Zeplin
    • With UX agree on the version of the implementation
  • Code review:
    • Open a pull request (or mark the existing draft PR as Ready for review) and ask @kirbydesign/kirby-guild for a review
      Remember to add closes #issueno to the description of the PR.
    • Once approved, merge feature branch/PR to master
  • Ask a member of @kirbydesign/kirby-guild to add a link to component showcase from Kirby Component Status and update the version number

🎉 Celebrate

@henrikvoetmand henrikvoetmand added enhancement New feature or request component:Button NOT Tech refined Needs Tech kickoff - solution outlined and agreed NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement labels Apr 27, 2021
@henrikvoetmand
Copy link
Collaborator Author

henrikvoetmand commented May 31, 2021

Tech refinement:

  • Search and replace "AttnLvl2" -> "AttnLvl3"
  • Ask UX to define where the black AttnLvl 2 is used by design
  • Consider major version of Kirby - due to visual breaking change
  • Inform UX about the scedule for this enhancement.
  • Consider how to handle AttnLvl4 in other components

@RasmusKjeldgaard
Copy link
Collaborator

A couple of small additions:
Ask UX first about the black AttnLvl 2 buttons, then search and replace all other instances than those. They should remain attention level 2.

W.r.t. the last point about AttnLvl 4: AttnLvl 4 should no longer be part of the external API, so internally we could instead look at the context of the button and style it accordingly.

@stale
Copy link

stale bot commented Aug 9, 2021

This issue has been automatically marked as stale because of no recent activity. It will be closed in 10 weeks if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatically applied when there is no activity on an issue or PR label Aug 9, 2021
@henrikvoetmand henrikvoetmand removed the stale Automatically applied when there is no activity on an issue or PR label Aug 10, 2021
@MadsBuchmann MadsBuchmann removed the 👶🏻 New For new issues before prioritisation and refinement label Sep 8, 2021
@alxzak alxzak added the Web label Oct 5, 2021
@RasmusKjeldgaard RasmusKjeldgaard added NOT Prioritized Issue not yet prioritized and added to a Milestone and removed NOT Prioritized Issue not yet prioritized and added to a Milestone labels Nov 10, 2021
@mictro mictro self-assigned this Dec 6, 2021
@mictro mictro removed NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Tech refined Needs Tech kickoff - solution outlined and agreed labels Dec 6, 2021
@alxzak alxzak moved this to In Progress in Kirby Jan 3, 2022
@alxzak alxzak added this to Kirby Jan 3, 2022
@alxzak alxzak moved this from In Progress to Impeeded in Kirby Jan 10, 2022
@MadsBuchmann MadsBuchmann moved this from Impeeded to Review pending in Kirby Jan 18, 2022
@alxzak alxzak added this to the M10 (x - 26/1 ) milestone Jan 20, 2022
@jkaltoft jkaltoft linked a pull request Jan 25, 2022 that will close this issue
7 tasks
@mictro mictro moved this from Review pending to Ready for next release in Kirby Jan 26, 2022
@alxzak alxzak removed this from the M10 (x - 26/1 ) milestone Jan 27, 2022
@alxzak alxzak added this to the M11 ( 27/1 - 6/4 ) milestone Jan 27, 2022
@alxzak alxzak added the Desktop components Only for issues regarding the desktop component epic label Mar 4, 2022
@MadsBuchmann MadsBuchmann moved this from 🟢 Ready for next release to ✅ Done in Kirby Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:Button Desktop components Only for issues regarding the desktop component epic enhancement New feature or request 🟢 Ready for release Web
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants