Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply outline to clickable card on touch devices #1946

Closed

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented Dec 17, 2021

Which issue does this PR close?

This PR closes #1944

What is the new behavior?

Touch-devices (iOS specifically) should no longer show focus outline on a clickable card.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be automatically merged to master via automerge.

@RasmusKjeldgaard RasmusKjeldgaard enabled auto-merge (squash) December 17, 2021 14:28
@RasmusKjeldgaard RasmusKjeldgaard removed the request for review from jkaltoft December 17, 2021 14:49
auto-merge was automatically disabled December 17, 2021 14:49

Pull request was closed

@jkaltoft jkaltoft deleted the bug/1944-focus-outline-touch-devices branch June 27, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Focus outline on clickable card is visible on iPhone
1 participant