Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Focus outline on clickable card is visible on iPhone #1944

Closed
1 of 9 tasks
Tracked by #2039
RasmusKjeldgaard opened this issue Dec 17, 2021 · 1 comment · Fixed by #2050
Closed
1 of 9 tasks
Tracked by #2039

[BUG] Focus outline on clickable card is visible on iPhone #1944

RasmusKjeldgaard opened this issue Dec 17, 2021 · 1 comment · Fixed by #2050
Assignees
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@RasmusKjeldgaard
Copy link
Collaborator

Describe the bug

The focus outline of the card is also visible on touch devices. It is a UX decision to now show the outline on these types of devices, and therefore we should probably use the not-touch mixin, for applying the outline styles.

Describe how to reproduce the bug

Only reproducible in drb project.

Which Kirby version was used?

4.0.16

What was the expected behavior?

No focus outline on touch devices, but still focus outline for desktop.

Add any screenshots

Please complete the following information:

  • OS: iOS
  • Browser: iOS Safari

Are there any additional context?


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@RasmusKjeldgaard RasmusKjeldgaard added bug NOT Prioritized Issue not yet prioritized and added to a Milestone 👶🏻 New For new issues before prioritisation and refinement NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Dec 17, 2021
@alxzak alxzak added this to Kirby Sep 20, 2022
@mictro mictro moved this to 🚀 In Progress in Kirby Nov 11, 2022
@mictro mictro self-assigned this Nov 11, 2022
@mictro
Copy link
Contributor

mictro commented Nov 14, 2022

Fixed by #2050

@mictro mictro closed this as completed Nov 14, 2022
Repository owner moved this from 🚀 In Progress to ✅ Done in Kirby Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 👶🏻 New For new issues before prioritisation and refinement NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Archived in project
2 participants