-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented CRUD operations for Product Module #45
Conversation
@khanhduzz Can you approve the further checks? |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
I’m swamped with deadlines at the company right now. I’m working on integrating Keycloak with Swagger and adding security to our services, so it might take me a bit longer to review your code. Please bear with me! Thank you @PALASH2201. |
product/src/main/java/com/fjb/product/controller/ProductController.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/controller/ProductController.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/controller/ProductController.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
@khanhduzz I have pulled the latest changes, any configurations I have to make in my local machine to run the latest changes? |
@PALASH2201 I have already setup some container and we will be able to run with Swagger, I will up a guideline tomorrow! So, you can follow it and run the project |
Ok, thanks! |
@PALASH2201 Hi Palash, I've updated the wiki with instructions on how to run the project. Please take a look! |
@khanhduzz Ok, I'll look into it. |
@khanhduzz I have tested it, working fine. Actually, I had a doubt about the try catch block in Controller , can you provide some sample as how do you want the exceptions to be handled? |
|
@khanhduzz I can do the Exception Handling, I just wanted to know how you want it to be implemented. |
Hi @PALASH2201, It seems there is an issue with a merge conflict. If you're unsure about how to resolve it, you might want to consider closing this PR, pulling the latest code from the main branch, and then creating a new PR. Thanks! |
@khanhduzz I have added the exception handling as instructed. |
product/src/main/java/com/fjb/product/controller/ProductController.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/repository/ProductRepository.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/service/ProductService.java
Outdated
Show resolved
Hide resolved
product/src/main/java/com/fjb/product/controller/ProductController.java
Outdated
Show resolved
Hide resolved
Hi @PALASH2201 , I already added some comments, please check it, thank you! |
@khanhduzz I added Sell-bff as a module, so maybe because of that it moved |
@PALASH2201 Omg, it's been a hectic day! I'll try to review everything tomorrow when I have more time. Thanks for your patience! |
@khanhduzz No problem, just that its been many days this pr is open thats why wanted to wrap this up |
Hi @PALASH2201, I've added some comments—please review them. Thank you so much for your great effort in tackling this issue. I'm looking forward to approving your PR. |
|
@khanhduzz I have made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PALASH2201 I believe we can improve some parts of this code later, but we can address that in a future PR. The first step is always the hardest, so I'll go ahead and approve this PR.
You can merge when have 2 approve, remember using Squash and merge, thank you!
@khanhduzz can you merge and add hacktoberfest-accepted label ? |
@PALASH2201 Do not need to add label, this repo is already registered. You can merge it |
Issue: #2
This PR introduces the following features to the project:
Testing:
Notes:
Please review the code changes and provide feedback.
I look forward to suggestions for improvements, especially concerning the security configuration.
Thank you for considering this PR!