Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design product with attributes #18

Open
khanhduzz opened this issue Oct 1, 2024 · 9 comments
Open

Design product with attributes #18

khanhduzz opened this issue Oct 1, 2024 · 9 comments
Labels

Comments

@khanhduzz
Copy link
Owner

No description provided.

@PALASH2201
Copy link
Contributor

@khanhduzz Here's my diagram draft:
image
What are your suggestions?

@PALASH2201
Copy link
Contributor

@khanhduzz Can you review this?

1 similar comment
@PALASH2201
Copy link
Contributor

@khanhduzz Can you review this?

@khanhduzz
Copy link
Owner Author

Hi @PALASH2201 , too busy these days, just a fast check, I think we can go with that diagram, you can implement the product with that all attributes, I think it maybe a little bit complicated, so you might break it into smaller task and make PR.

And please trying to write clean and easy to read code, thank you!

@PALASH2201
Copy link
Contributor

@khanhduzz Can I change the add the .md doc for the same in docs folder? Should I issue a PR for same?

@khanhduzz
Copy link
Owner Author

@PALASH2201 So, what do you mean? You want to add the diagram to the docs? You can make a PR for that.

@PALASH2201
Copy link
Contributor

ok, will issue a PR

@PALASH2201
Copy link
Contributor

@khanhduzz please review the PR

@PALASH2201
Copy link
Contributor

@khanhduzz I just finished my Semester exam, will start implementing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants