-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design product with attributes #18
Comments
@khanhduzz Here's my diagram draft: |
@khanhduzz Can you review this? |
1 similar comment
@khanhduzz Can you review this? |
Hi @PALASH2201 , too busy these days, just a fast check, I think we can go with that diagram, you can implement the product with that all attributes, I think it maybe a little bit complicated, so you might break it into smaller task and make PR. And please trying to write clean and easy to read code, thank you! |
@khanhduzz Can I change the add the .md doc for the same in docs folder? Should I issue a PR for same? |
@PALASH2201 So, what do you mean? You want to add the diagram to the docs? You can make a PR for that. |
ok, will issue a PR |
@khanhduzz please review the PR |
@khanhduzz I just finished my Semester exam, will start implementing it |
No description provided.
The text was updated successfully, but these errors were encountered: