Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part4 Freec as default: Chromosome wide CNV plots per histology #4

Merged
merged 4 commits into from
May 7, 2021

Conversation

kgaonkar6
Copy link
Owner

@kgaonkar6 kgaonkar6 commented Apr 7, 2021

Purpose/implementation Section

What scientific question is your analysis addressing?

Similar to #3 we are propogating the changes proposed in AlexsLemonade#987 to use freec CN calls as default to some modules that plot the CNV changes.
In this PR we will use the updated consensus_seg_most_focal_cn_status.tsv.gz from #2 as input to recreate chromosome wide plots.

What was your approach?

Just re-run cn_status_heatmap.Rmd and gistic_plot.Rmd

What GitHub issue does your pull request address?

related to AlexsLemonade#964

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Not sure which data release was used to generate these plots before but there are some histologies (like "CNS neuroblastoma" ) which have now been renamed (Neuroblastoma) so please be keep a note of that while tracking files that have/have ot changed by this update.

There are also sample number changes which are not related to the update here but are dependent on data release.

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

Yes

What is your summary of the results?

I continue to see gains (because I guess I'm looking for those) in the updated files for example chr15 in LGAT_plot.png didn't have any gain in the plot in master branch but the file in this branch does have gains.

file in chrom_plot branch
LGAT_plot

file in master branch
image

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@kgaonkar6 kgaonkar6 merged commit 86ebece into oncoprint May 7, 2021
@kgaonkar6 kgaonkar6 deleted the chrom_plot branch May 13, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant