Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part3 Freec as default: Oncoprint update #3

Merged
merged 8 commits into from
May 7, 2021
Merged

Conversation

kgaonkar6
Copy link
Owner

@kgaonkar6 kgaonkar6 commented Apr 7, 2021

Purpose/implementation Section

What scientific question is your analysis addressing?

We updated the consensus seg file creation in AlexsLemonade#987 to use freec CN calls as default .
A re-run focal-cn-file-preparation updated results/consensus_seg_most_focal_cn_status.tsv.gz in AlexsLemonade#988 .
In this PR we will use the updated consensus_seg_most_focal_cn_status.tsv.gz as input and re-create the oncoplots.

What was your approach?

Just run run-oncoprint.sh

What GitHub issue does your pull request address?

related to AlexsLemonade#964

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Yes

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

There are no drastic changes it seems to me.

However , since in #2 we start seeing that majority of the changes are losses that are now gains , I also see all the losses change to gains in the oncoplot!!

Figure in this branch
https://github.com/kgaonkar6/OpenPBTA-analysis/blob/oncoprint/analyses/oncoprint-landscape/plots/all_participants_primary_only_goi_oncoprint.png

Figure in master branch
https://github.com/kgaonkar6/OpenPBTA-analysis/blob/master/analyses/oncoprint-landscape/plots/all_participants_primary_only_goi_oncoprint.png

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@kgaonkar6 kgaonkar6 merged commit d28c648 into focal-cn-update May 7, 2021
@kgaonkar6 kgaonkar6 deleted the oncoprint branch May 13, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant