Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run "make format" #3588

Closed

Conversation

wolframroesler
Copy link
Contributor

Someone probably forgot to run "make format" before committing their changes, which means that everyone else who runs "make format" has to revert these files because they don't want them in their commits. So, I'm submitting a commit with a clean "make format" for everyone.

Type of change

  • ✅ Refactor (significant modification to existing code)

Description and Context

Run "make format". No semantic changes.

Screenshots

n/a

Testing strategy

Superficial manual tests of the resulting executable, including "make test". No changed behavior expected however.

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

Someone probably forgot to run "make format" before committing
their changes, which means that everyone else who runs "make
format" has to revert these files because they don't want them
in their commits. So, I'm submitting a commit with a clean
"make format" for everyone.
@droidmonkey
Copy link
Member

This should be done as part of an existing PR

@wolframroesler
Copy link
Contributor Author

Done on #3546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants