Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statistics panel in Database Settings dialog #3546

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Statistics panel in Database Settings dialog #3546

merged 1 commit into from
Oct 13, 2019

Conversation

wolframroesler
Copy link
Contributor

Type of change

  • ✅ New feature (non-breaking change which adds functionality)

Description and Context

Added new page "Statistics" to the Database Settings dialog that shows information like number of groups and entries, number of unique and re-used passwords, average password length, etc.

Fixes #2034.

Screenshots

Screenshot from 2019-09-16 21 33 46

Testing strategy

Tested manually using my own database and the test database in the share folder (test.kdbx).

Checklist:

  • ✅ I have read the CONTRIBUTING document. [REQUIRED]
  • ✅ My code follows the code style of this project. [REQUIRED]
  • ✅ All new and existing tests passed. [REQUIRED]
  • ✅ I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious
Copy link
Member

phoerious commented Sep 16, 2019 •
edited
Loading

Great feature. Perhaps use a different widget than a table, though? I think it uses up too much space and I don't really like the stripes. I think two columns of simple labels side by side with the left column being right-aligned would be better. Tables for key-value pairs are always a little wacky anyway.

@droidmonkey
Copy link
Member

I kinda like it, quick and easy

@wolframroesler
Copy link
Contributor Author

wolframroesler commented Sep 27, 2019 •
edited
Loading

The Linux build error reported by TeamCity is a failure in "make test", the error message is:

[17:19:53][Step 4/5] 19/37 Test #19: testautotype .....................***Exception: Other  0.25 sec
[17:19:53][Step 4/5] ********* Start testing of TestAutoType *********
[17:19:53][Step 4/5] Config: Using QtTest library 5.3.2, Qt 5.3.2
[17:19:53][Step 4/5] QFATAL : TestAutoType::initTestCase() ASSERT: "openResult" in file /opt/buildagent/work/c401303cba1b4098/src/core/Config.cpp, line 257
[17:19:53][Step 4/5] FAIL!  : TestAutoType::initTestCase() Received a fatal error.
[17:19:53][Step 4/5]    Loc: [Unknown file(0)]
[17:19:53][Step 4/5] Totals: 0 passed, 1 failed, 0 skipped
[17:19:53][Step 4/5] ********* Finished testing of TestAutoType *********

Works fine for me (also on Linux). Doesn't seem to have anything to do with my changes since I changed nothing about AutoType. Any ideas?

@droidmonkey
Copy link
Member

We are working through issues on the Linux CI.

@phoerious
Copy link
Member

Fixed.

This was referenced Sep 29, 2019
Closed
Closed
@droidmonkey droidmonkey added this to the v2.5.0 milestone Oct 5, 2019
@droidmonkey
Copy link
Member

I added stats for number of short and weak passwords. Also cleaned up the code.

@droidmonkey droidmonkey removed the request for review from phoerious October 13, 2019 15:40
@wolframroesler @droidmonkey
Add "Statistics" page to Database Settings dialog (keepassxreboot#2034)
dd13846 
Added new page "Statistics" to the Database Settings dialog that shows information like number of groups and entries, number of unique and re-used passwords, average password length, etc.
Show warnings for problematic values with explainations for the user in tooltips.

Fixes keepassxreboot#2034

Database statistics icon:
Downloaded from: https://www.flaticon.com/authors/freepik
Original source: https://www.flaticon.com/free-icon/bars-chart_265733
@droidmonkey droidmonkey merged commit 8afb1f1 into keepassxreboot:develop Oct 13, 2019
@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surkin surkin surkin approved these changes

@droidmonkey droidmonkey droidmonkey approved these changes

Assignees
No one assigned
Labels
bounty 💰 pr: new feature Pull request that adds a new feature user interface
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

Database information / statistics panel [$50 awarded]
4 participants
@wolframroesler @phoerious @droidmonkey @surkin