Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Developer experience Improvements #1548

Merged
merged 10 commits into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: Task - Integration Tests
name: Task - Test Coverage

on:
workflow_dispatch:
Expand Down
14 changes: 0 additions & 14 deletions .github/workflows/pull-request-close.yml

This file was deleted.

5 changes: 5 additions & 0 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ jobs:
uses: ./.github/workflows/linters-cargo.yml
needs: madara_commands

coverage:
name: Run code coverage
uses: ./.github/workflows/coverage.yml
needs: madara_commands

rpc-tests:
name: Run rpc tests
uses: ./.github/workflows/starknet-rpc-tests.yml
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Next release

- chore: add makefile for developer experience improvements and cleanup
- Fix(node): Fix creating a local testnet with multiple nodes fails using only
cli flags
- dev: change `Vec::new` to `Vec::with_capacity` where possible.
Expand Down
34 changes: 34 additions & 0 deletions makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
.PHONY: check fix prt fmt clip tap test help

fix:
npx prettier --write .
cargo fmt
taplo fmt --config ./taplo/taplo.toml
cargo clippy --workspace --tests --no-deps --fix -- -D warnings

check: prt fmt clip tap

prt:
npx prettier --check .

fmt:
cargo fmt -- --check

clip:
cargo clippy --workspace --tests --no-deps -- -D warnings

tap:
taplo fmt --config ./taplo/taplo.toml --check

test:
cargo test

help:
@echo "Available targets:"
@echo " check - Run all checks (prt, fmt, clip, tap)"
@echo " fix - Fix code formatting and linting issues"
@echo " prt - Check code formatting with Prettier"
@echo " fmt - Check code formatting with rustfmt"
@echo " clip - Run Clippy linter"
@echo " tap - Check configuration file formatting with Taplo"
@echo " test - Run tests"
Loading