Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Developer experience Improvements #1548

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Apr 2, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Other (please describe):
    • Developer experience update of adding in a makefile for easy check and fixing linting issues.
    • Places Coverage ci test into the general PR workflow
    • General cleanup of unused files

Does this introduce a breaking change?

No

@hhamud hhamud marked this pull request as ready for review April 2, 2024 01:11
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.05%. Comparing base (2e2d580) to head (87170d4).
Report is 207 commits behind head on main.

❗ Current head 87170d4 differs from pull request most recent head 0b8c10c. Consider uploading reports for the commit 0b8c10c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1548      +/-   ##
==========================================
- Coverage   40.71%   34.05%   -6.67%     
==========================================
  Files          96       95       -1     
  Lines       11069     9130    -1939     
  Branches    11069     9130    -1939     
==========================================
- Hits         4507     3109    -1398     
+ Misses       6050     5545     -505     
+ Partials      512      476      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hhamud hhamud changed the title Chore/improv Developer experience Improvements Apr 2, 2024
@hhamud
Copy link
Contributor Author

hhamud commented Apr 2, 2024

@apoorvsadana @Matth26 @tdelabro can you review this?

@apoorvsadana apoorvsadana merged commit c7ac4cc into keep-starknet-strange:main Apr 11, 2024
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants