Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

✨ add state_diff to trace API #1390

Merged
merged 31 commits into from
Mar 5, 2024

Conversation

EvolveArt
Copy link
Collaborator

@EvolveArt EvolveArt commented Jan 22, 2024

What is the current behavior?

Resolves: #1331

What is the new behavior?

  • Creates a new CachedBlockifierStateAdapter struct that's only being used in the tracing runtime API, it uses the blockifier caching mechanism to output a state diff after each transaction.
  • This state diff is then propagated to the simulateTransactions endpoint.

Does this introduce a breaking change?

No

Other information

@tdelabro tdelabro self-requested a review January 22, 2024 15:07
@tdelabro tdelabro added the feature New feature label Jan 22, 2024
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

execute_txs_and_rollback should not waste computation during estimate_fee

@EvolveArt EvolveArt requested a review from tdelabro January 23, 2024 11:09
@EvolveArt EvolveArt requested a review from tdelabro January 24, 2024 11:51
@EvolveArt EvolveArt merged commit c06c385 into keep-starknet-strange:main Mar 5, 2024
12 of 18 checks passed
@EvolveArt EvolveArt deleted the feat/trace-state-diff branch March 5, 2024 09:59
SamrendraS pushed a commit to SamrendraS/madara that referenced this pull request Mar 5, 2024
Co-authored-by: Timothée Delabrouille <34384633+tdelabro@users.noreply.github.com>
MrishoLukamba pushed a commit to MrishoLukamba/madara that referenced this pull request Mar 6, 2024
Co-authored-by: Timothée Delabrouille <34384633+tdelabro@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(rpc): Compute state diff fields in get_state_update/simulate_transaction
2 participants