Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

feat(rpc): Compute state diff fields in get_state_update/simulate_transaction #1331

Closed
antiyro opened this issue Dec 25, 2023 · 1 comment · Fixed by #1378 or #1390
Closed

feat(rpc): Compute state diff fields in get_state_update/simulate_transaction #1331

antiyro opened this issue Dec 25, 2023 · 1 comment · Fixed by #1378 or #1390
Assignees
@EvolveArt
Labels
enhancement New feature or request

Comments

@antiyro
Copy link
Contributor

antiyro commented Dec 25, 2023

feat(rpc): Compute state diff fields in get_state_update/simulate_transaction

Currently they're 2 implementations of StateDiff within madara:

  1. One used from starknet.rs defaulted in get_state_update
  2. A copy of the Starknet rs implementation supporting encode/decode parity scale codec trait supported by madara

The goal of this issue would be to assign everywhere the seconde implementation of state diff field (located under mp-state still to be merged in #1313) and compute it correctly in get_state_update/simulate_transaction rpc based on v0.5.1 rpc specs as defined here
@antiyro antiyro added the enhancement New feature or request label Dec 25, 2023
@antiyro antiyro mentioned this issue Dec 25, 2023
Closed
@antiyro
Copy link
Contributor Author

antiyro commented Jan 6, 2024

@EvolveArt are you taking this one?

This was referenced Jan 17, 2024
Merged
Merged
@EvolveArt EvolveArt self-assigned this Jan 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EvolveArt EvolveArt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ get_state_update EvolveArt/kaioshin
✨ add state_diff to trace API EvolveArt/kaioshin
2 participants
@EvolveArt @antiyro