Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for fatal crash on app open #315

Merged
merged 5 commits into from
Jan 9, 2018
Merged

Conversation

wethinkagile
Copy link
Contributor

please merge

@dylanvdmerwe
Copy link

Please can this be merged and released. This plugin does not work with WkWebView which is hugely problematic.

@mino922
Copy link

mino922 commented Oct 6, 2017

Please merge this. I have tested and this fixes the issue.

@dylanvdmerwe
Copy link

@katzer

@westphalen
Copy link

Is there any reason this has not been merged?
This fixed my app from crashing on launch (iOS), but I'm wondering if there is any consequences to using it.

@katzer katzer merged commit 7285bec into katzer:master Jan 9, 2018
@katzer
Copy link
Owner

katzer commented Jan 9, 2018

Thanks

@mino922
Copy link

mino922 commented Jan 14, 2018

I verified that this is working, however when running ionic cordova plugin add cordova-plugin-background-mode I am getting the old code.

Does anyone know how to get that updated so it is pulling the latest?

@hi-rad
Copy link

hi-rad commented Feb 2, 2018

@mino922 I am having the same problem
@katzer is this plugin fixed? My app wont work (iOS 11) when I use ionic cordova plugin add cordova-plugin-background-mode If not, when are you planning to publish a fix for it?

@mino922
Copy link

mino922 commented Feb 2, 2018

The npm repo is not up to date. Run ionic cordova plugin add https://github.com/katzer/cordova-plugin-background-mode

@ZaLiTHkA
Copy link

installing directly from the GitHub URL gets me a usable copy of this plugin, but it seems this is no longer fully compatible with the @ionic-native wrapper created for it...

any chance we can get the current master branch version incremented and a new release on NPM? that should help motivate the required updates in the Ionic Native project for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants