Skip to content

Commit

Permalink
fix for fatal crash on app open (#315)
Browse files Browse the repository at this point in the history
* bugfix for WKWebViewEngine app crash

* fixing package.json

* fixing package.json

* reverting package.json for pull request

* reverting package.json for pull request
  • Loading branch information
Stephan Kristyn authored and katzer committed Jan 9, 2018
1 parent e939b13 commit 7285bec
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ This software is released under the [Apache 2.0 License][apache2_license].

Made with :yum: from Leipzig

© 2017 [appPlant GmbH][appplant]
? 2017 [appPlant GmbH][appplant] & [meshfields][meshfields]


[cordova]: https://cordova.apache.org
Expand All @@ -205,3 +205,4 @@ Made with :yum: from Leipzig
[changelog]: CHANGELOG.md
[apache2_license]: http://opensource.org/licenses/Apache-2.0
[appplant]: http://appplant.de
[meshfields]: http://meshfields.de
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,4 @@
"url": "https://github.com/katzer/cordova-plugin-background-mode/issues"
},
"homepage": "https://github.com/katzer/cordova-plugin-background-mode#readme"
}
}
2 changes: 1 addition & 1 deletion src/ios/APPBackgroundMode.m
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ + (void) swizzleWKWebViewEngine
forKey:[APPBackgroundMode wkProperty]];

[obj setValue:[NSNumber numberWithBool:NO]
forKey:@"_requiresUserActionForMediaPlayback"];
forKey:@"requiresUserActionForMediaPlayback"];

return obj;
}
Expand Down

1 comment on commit 7285bec

@debugger200
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is not merged to stable branch (cordova plugin add cordova-plugin-background-mode). This fix is available in latest ahead revision (cordova plugin add https://github.com/katzer/cordova-plugin-background-mode.git)

Why dont we merge this fix? it is needed.

Fix: 7285bec#diff-58c42aa53007297851f6b73bf0011ccd

Please sign in to comment.