Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Revert the refactoring of RAGEngineStatus and WorkspaceStatus #636

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: Revert the refactoring of RAGEngineStatus and WorkspaceStatus #636

merged 2 commits into from
Oct 17, 2024

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
Revert the refactoring of RAGEngineStatus and WorkspaceStatus

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Bangqi Zhu added 2 commits October 17, 2024 11:24
Revert "feat: refact updateStatusConditionIfNotMatch for both RAG and…
65382b1 
… workspace (#626)"

This reverts commit 152e683.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Revert "feat: refactor updateObjStatus for both RAG and workspace (#625…
7f11e70 
…)"

This reverts commit 920ada5.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.31461% with 46 lines in your changes missing coverage. Please review.

Project coverage is 54.45%. Comparing base (5c30038) to head (7f11e70).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/workspace_controller.go 16.36% 39 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   58.18%   54.45%   -3.74%     
==========================================
  Files          30       34       +4     
  Lines        2987     3928     +941     
==========================================
+ Hits         1738     2139     +401     
- Misses       1149     1683     +534     
- Partials      100      106       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit 314a80e into main Oct 17, 2024
6 of 8 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/revert_status_refact branch October 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangqipropel @Fei-Guo