Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor updateObjStatus for both RAG and workspace #625

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
refactor updateObjStatus for both RAG and workspace

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.73%. Comparing base (5c30038) to head (4568431).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/workspace_status.go 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
- Coverage   58.18%   54.73%   -3.46%     
==========================================
  Files          30       34       +4     
  Lines        2987     3234     +247     
==========================================
+ Hits         1738     1770      +32     
- Misses       1149     1358     +209     
- Partials      100      106       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit 920ada5 into main Oct 13, 2024
7 of 8 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/refactor_updateObjStatus branch October 13, 2024 20:40
bangqipropel pushed a commit that referenced this pull request Oct 17, 2024
…)"

This reverts commit 920ada5.

Signed-off-by: Bangqi Zhu <bangqizhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants