Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SKU modularization] remove sku_config from v1alpha1 and implement skuHandler interface #602

Merged
merged 2 commits into from
Sep 20, 2024

address PR comment

d47fce4
Select commit
Loading
Failed to load commit list.
Merged

feat: [SKU modularization] remove sku_config from v1alpha1 and implement skuHandler interface #602

address PR comment
d47fce4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 20, 2024 in 1s

68.75% of diff hit (target 58.18%)

View this Pull Request on Codecov

68.75% of diff hit (target 58.18%)

Annotations

Check warning on line 302 in api/v1alpha1/workspace_validation.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

api/v1alpha1/workspace_validation.go#L301-L302 

Added lines #L301 - L302 were not covered by tests

Check warning on line 155 in pkg/utils/common-preset.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/utils/common-preset.go#L154-L155 

Added lines #L154 - L155 were not covered by tests
View more details on Codecov