Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SKU modularization] remove sku_config from v1alpha1 and implement skuHandler interface #602

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

smritidahal653
Copy link
Contributor

Reason for Change:

  • sku_config is Azure cloud specific, this is replaced by skuHandler interface as a part of the effort to modularize gpu skus. Deleting it from the v1alpha1 package
  • Implementing skuHandler to get gpu configs in place where SupportedGPUConfigs was used from sku_config file
  • Fixing test cases to use updated skus after skuHandler implementation

Requirements

  • added unit tests and e2e tests (if applicable).

Notes for Reviewers:

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.71%. Comparing base (5c30038) to head (d47fce4).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
api/v1alpha1/workspace_validation.go 72.72% 2 Missing and 1 partial ⚠️
pkg/utils/common-preset.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
- Coverage   58.18%   55.71%   -2.48%     
==========================================
  Files          30       30              
  Lines        2987     3116     +129     
==========================================
- Hits         1738     1736       -2     
- Misses       1149     1279     +130     
- Partials      100      101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fei-Guo Fei-Guo merged commit a06cf97 into main Sep 20, 2024
7 of 9 checks passed
@Fei-Guo Fei-Guo deleted the sdahal/sku branch September 20, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants