Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update karpenter nodeclass #570

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Aug 19, 2024

Reason for Change:

  • Enable workspace controller to manage karpenter providers objects to be able to create the NodeClass.
  • Remove the node affinity condition that applies on gpu-provisioner and will not allow Karpenter.
  • add scheme registration for Karpenter CRDs
  • cleanup the NodeClass code.
  • Add unit tests for NodeClass.
  • Update the suite parameter to node_provisioner

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 58.19%. Comparing base (3db011e) to head (5aa742f).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/nodeclaim/nodeclaim.go 50.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   56.54%   58.19%   +1.65%     
==========================================
  Files          30       30              
  Lines        2966     2978      +12     
==========================================
+ Hits         1677     1733      +56     
+ Misses       1191     1144      -47     
- Partials       98      101       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty changed the title feat: Update workspace chart and update karpenter nodeclass feat: Update karpenter nodeclass Aug 20, 2024
@helayoty helayoty merged commit 9d42673 into main Aug 20, 2024
9 of 10 checks passed
@helayoty helayoty deleted the helayoty/chart-karpenter-main branch August 20, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants