Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for Karpenter in the kaito pipelines #569

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Aug 19, 2024

Reason for Change:

  • Update e2e pipelines in order to be able to check the gpu-provisioner and Karpenter use cases. This will be handled by adding a new input variable nodeprovisioner for the workflow_call.
  • Add make target to install karpenter.
  • Unify the variable names used in e2e tests.
  • Simplified the e2e pipeline by using the generate identities script.
  • Use GH variables to pass the k8s version. AKS_K8S_VERSION

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (1f06382) to head (6345eef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   56.54%   56.54%           
=======================================
  Files          30       30           
  Lines        2966     2966           
=======================================
  Hits         1677     1677           
  Misses       1191     1191           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty merged commit 3db011e into main Aug 20, 2024
8 checks passed
@helayoty helayoty deleted the helayoty/karpenter-pipelines branch August 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants