Produce request encoding performance improvement #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k32
reviewed
Feb 29, 2020
f1d6859 to
a730987
Compare
a730987 to
63a46b7
Compare
|
@k32 possible to merge this one ? |
|
sorry. hold on. |
|
now @k32 please take a look again. |
Aslo added a simle eunit test to benchmark produce request encoding before/after performance this patch speeds up encoding around 35%
The naive idea was to ensure binary so nif should not need to copy iolist as binary (it would take the already carated binary directly)
6dd5d3f to
03396e6
Compare
k32
approved these changes
Mar 23, 2020
|
Thank you! |
turtleDeng
pushed a commit
to emqx/kafka_protocol
that referenced
this pull request
Jan 11, 2021
* Produce request encoding performance improvement (kafka4beam#69) * Improve produce request encoding performance Also added a simple eunit test to benchmark produce request encoding before/after performance this patch speeds up encoding around 35% * Allow #kpro_msg.msg to be iodata() * Delete remote call to iolist_size * No need to make binary for enif_inspect_iolist_as_binary The naive idea was to ensure binary so nif should not need to copy iolist as binary (it would take the already created binary directly) * Avoid iolist_to_binary when encoding string * Upgrade snappyer and crc32cer deps to support windows (kafka4beam#73) * fix(connection): back pressure for send API even when no_ack * chore(appup): pin version 2.3.6.1 and add appup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
produce request encoding is the most critical code path.
judging by the naive bechmark (light version added as a eunit test),
the time cost to complete the eunit case is improved by about 35%