fix(connection): back pressure for send API even when no_ack #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve produce request encoding performance Also added a simple eunit test to benchmark produce request encoding before/after performance this patch speeds up encoding around 35% * Allow #kpro_msg.msg to be iodata() * Delete remote call to iolist_size * No need to make binary for enif_inspect_iolist_as_binary The naive idea was to ensure binary so nif should not need to copy iolist as binary (it would take the already created binary directly) * Avoid iolist_to_binary when encoding string
turtleDeng
approved these changes
Jan 8, 2021
|
Please add appup file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.