Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to kpro 4 #459

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Update to kpro 4 #459

merged 5 commits into from
Jul 7, 2021

Conversation

tpitale
Copy link

@tpitale tpitale commented Jun 1, 2021 •
edited
Loading

Update to kpro 4

  • fix updates to field names
  • update to kpro 4 includes fixes for delete_topics field names

make ut is passing

make t is passing, except for any use of snappyer compress. Investigating, but any assistance would be appreciated.

Related to #69.

@tpitale
Copy link
Author

tpitale commented Jun 1, 2021

cc @zmstone

@tpitale
Copy link
Author

tpitale commented Jun 1, 2021

Also related: #454

@zmstone
Copy link
Contributor

zmstone commented Jun 18, 2021

sorry for the late review @tpitale
could you rebase on latest master? we have fixed the CI there

@zmstone
Copy link
Contributor

zmstone commented Jun 18, 2021

Please help to update the TODO list in README.md

@tpitale tpitale force-pushed the update-to-kpro-4 branch from efea562 to c9c31a0 Compare June 18, 2021 13:23
@tpitale
Copy link
Author

tpitale commented Jun 18, 2021

@zmstone

  1. Should I remove the line about kafka protocol from the todos?
  2. What version should be next in the changelog? 3.16.0 maybe?

@zmstone
Copy link
Contributor

zmstone commented Jun 19, 2021 •
edited
Loading

@zmstone

  1. Should I remove the line about kafka protocol from the todos

yes

  1. What version should be next in the changelog? 3.16.0 maybe?

yes

thank you.

@tpitale
Copy link
Author

tpitale commented Jun 30, 2021

@zmstone Made those changes. What do you think I should do with the snappyer errors?

@zmstone zmstone force-pushed the update-to-kpro-4 branch from 8a08bdd to dea5188 Compare July 7, 2021 19:13
@zmstone
Copy link
Contributor

zmstone commented Jul 7, 2021

@zmstone Made those changes. What do you think I should do with the snappyer errors?

sorry for the delay.
I pushed a commit to your branch.

@zmstone
add snappyer as dependency
5557081 
In order to make compression libraries plugable, kafka_protocol 4.0
has compression libs deleted (not compatible to kafka_protoco 3.x).

To make it backward compatible for brod, we add snappyer dependency
to brod instead.
@zmstone zmstone force-pushed the update-to-kpro-4 branch from dea5188 to 5557081 Compare July 7, 2021 19:27
@zmstone zmstone merged commit 9785d72 into kafka4beam:master Jul 7, 2021
@zmstone
Copy link
Contributor

zmstone commented Jul 7, 2021

thank you @tpitale
3.16.0 has been tagged and published to hex.pm.

@tpitale
Copy link
Author

tpitale commented Jul 7, 2021

Thank you!

@tpitale tpitale deleted the update-to-kpro-4 branch July 11, 2021 01:47
@belltoy belltoy mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmstone zmstone zmstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpitale @zmstone