Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lz4 compression #69

Closed
zmstone opened this issue May 18, 2016 · 10 comments
Closed

lz4 compression #69

zmstone opened this issue May 18, 2016 · 10 comments

Comments

@zmstone
Copy link
Contributor

zmstone commented May 18, 2016

No description provided.

@zmstone zmstone added this to the 2.2 milestone May 18, 2016
@zmstone zmstone modified the milestones: 2.3, 2.2 Oct 10, 2016
@zmstone zmstone removed this from the 2.4 milestone Jul 26, 2018
@XOfSpades
Copy link

Is a support of lz4 planned in near future?

@zmstone
Copy link
Contributor Author

zmstone commented Aug 9, 2018

@XOfSpades yes we have.
it's a work in progress.

@zmstone
Copy link
Contributor Author

zmstone commented Oct 21, 2020

@qzhuyan
Copy link
Contributor

qzhuyan commented Oct 21, 2020

Right I forget about my PR, will fix this week.

@zmstone
Copy link
Contributor Author

zmstone commented Oct 21, 2020

it's to be added to kafka_protocol

@zmstone zmstone closed this as completed Feb 27, 2021
@zmstone
Copy link
Contributor Author

zmstone commented Feb 27, 2021

The latest kafka_protocol supports (a configurable callback) lz4 compression.
However it's not available to brod yet.
We will back port the feature to kafka_protocol 2.x
created this to follow up: kafka4beam/kafka_protocol#88

Reopen this issue so we can follow up the changes in brod too

@zmstone zmstone reopened this Feb 27, 2021
@tpitale
Copy link

tpitale commented Apr 28, 2021

Is there a reason brod hasn't updated to the latest kafka_protocol yet? Not sure if the changes are incompatible or something.

@zmstone
Copy link
Contributor Author

zmstone commented Apr 28, 2021

Is there a reason brod hasn't updated to the latest kafka_protocol yet? Not sure if the changes are incompatible or something.

hi. @tpitale, mostly because I have not managed to get the time for it.

The changes in kafka_protocol are incompatible.
But hopefully we should be able to keep brod APIs compatible

@tpitale
Copy link

tpitale commented Apr 28, 2021

@zmstone I'm happy to take a run at the changes if you can point me in the general direction.

@zmstone
Copy link
Contributor Author

zmstone commented Apr 29, 2021

@tpitale it's very nice of you to offer help.
let's move the discussion here: #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants