test: added tests for mutating webhook analyzer #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55e9c18 to
ec7e5ba
Compare
|
@matthisholleville, The following lines indicate that if the service selectors are empty, this request should be deferred to the service analyzer. However, no call to the service analyzer is being made. Is this intentional? k8sgpt/pkg/analyzer/mutating_webhook.go Line 86 in 4065fae k8sgpt/pkg/analyzer/validating_webhook.go Line 84 in 4065fae |
AlexsJones
approved these changes
Mar 5, 2024
ec7e5ba to
fc6710e
Compare
JuHyung-Son
approved these changes
Mar 6, 2024
This commit introduces comprehensive tests for the mutating webhook analyzer defined in the `pkg/analyzer` package. Adding these tests increases the code coverage of the `mutating_webhook.go` file to almost 95%. Partially addresses: k8sgpt-ai#889 Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
fc6710e to
8fa3990
Compare
Done, and I've also added comments for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This commit introduces comprehensive tests for the mutating webhook analyzer defined in the
pkg/analyzerpackage.Adding these tests increases the code coverage of the
mutating_webhook.gofile to almost 95%.Partially addresses: #889
✅ Checks