Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added tests for the Node analyzer #1014

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

VaibhavMalik4187
Copy link
Contributor

📑 Description

  • Added new tests for the Node analyzer defined in the pkg/analyzer package.

  • The addition of these new tests has increased the code coverage of the node.go file to over 96%.

Partially addresses: #889

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@VaibhavMalik4187 VaibhavMalik4187 requested review from a team as code owners March 13, 2024 10:00
@VaibhavMalik4187 VaibhavMalik4187 marked this pull request as draft March 13, 2024 10:03
@VaibhavMalik4187
Copy link
Contributor Author

Converting this to a draft PR until #1011 gets merged and the flaky tests are taken care of.

Copy link
Member

@arbreezy arbreezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* Added new tests for the `Node` analyzer defined in the `pkg/analyzer`
  package.

* The addition of these new tests has increased the code coverage of the
  node.go file to over 96%.

Partially addresses: k8sgpt-ai#889

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@VaibhavMalik4187 VaibhavMalik4187 marked this pull request as ready for review March 14, 2024 18:15
@VaibhavMalik4187
Copy link
Contributor Author

lgtm

Thanks, now it's ready for merging.

@AlexsJones AlexsJones merged commit a1d0d0a into k8sgpt-ai:main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants