Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added tests for the Service analyzer #1011

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

VaibhavMalik4187
Copy link
Contributor

📑 Description

  • Added new tests for the Service analyzer defined in the pkg/analyzer package.

  • The addition of these new tests has increased the code coverage of the service.go file to over 97%.

  • Additionally addressed some flaky tests related to the ReplicaSetand PersisentVolumeClaim analyzers.

Partially addresses: #889

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

* Added new tests for the `Service` analyzer defined in the
  `pkg/analyzer` package.

* The addition of these new tests has increased the code coverage of the
  service.go file to over 97%.

* Additionally addressed some flaky tests related to the `ReplicaSet`and
  `PersisentVolumeClaim` analyzers.

Partially addresses: k8sgpt-ai#889

Signed-off-by: VaibhavMalik4187 <vaibhavmalik2018@gmail.com>
@AlexsJones AlexsJones merged commit 531f0bc into k8sgpt-ai:main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants