Improve regexp invalid modifiers errors #145
Merged
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When it comes to valid regex flags that are invalid in this position (e.g. u, or g), it would be nice to get an error pointing exactly to that flag. |
JLHwung
commented
Oct 1, 2024
parser.js
Outdated
| if(match("-")){ | ||
| disablingFlags = matchReg(/^[sim]+/); | ||
| if(enablingFlags[2] === "-") { | ||
| disablingFlags = matchReg(/^([sim]+):/); |
There was a problem hiding this comment.
Aside: Here we disallows the production (?i-:foo) when the enablingFlags are non-empty and the disablingFlags are empty. The current spec draft does allow such productions and the V8 engine supports it well. I have raised a comment in the spec draft review (tc39/ecma262#3221 (comment)). If the spec is deemed no change here, I will open a new PR to fix that.
|
Thank you for the PR @JLHwung and @nicolo-ribaudo for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate different errors for two equivalent invalid expressions:
In this PR we improve the parsing logic so that the latter case now throws the same error as the former. We also aligned the production names to the latest draft.