Merge pull request #145 from babel/improve-regexp-invalid-modifiers-e…

…rrors Improve regexp invalid modifiers errors
jviereck · Oct 3, 2024 · 6ad7019 · 6ad7019
2 parents ccc838b + a376130
commit 6ad7019
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 5 deletions.
diff --git a/parser.js b/parser.js
@@ -216,9 +216,15 @@
 // --------------------------------------------------------------
 //
 // Atom ::
-//      ( ? RegularExpressionFlags : Disjunction )
-//      ( ? RegularExpressionFlags - RegularExpressionFlags : Disjunction )
+//      ( ? RegularExpressionModifiers : Disjunction )
+//      ( ? RegularExpressionModifiers - RegularExpressionModifiers : Disjunction )
 //
+// RegularExpressionModifiers:
+//      [empty]
+//      RegularExpressionModifiers RegularExpressionModifier
+//
+// RegularExpressionModifier:
+//      one of i m s
 
 "use strict";
 (function() {
@@ -747,8 +753,8 @@
       //      \ AtomEscape
       //      CharacterClass
       //      ( GroupSpecifier Disjunction )
-      //      ( ? RegularExpressionFlags : Disjunction )
-      //      ( ? RegularExpressionFlags - RegularExpressionFlags : Disjunction )
+      //      ( ? RegularExpressionModifiers : Disjunction )
+      //      ( ? RegularExpressionModifiers - RegularExpressionModifiers : Disjunction )
       // ExtendedAtom ::
       //      ExtendedPatternCharacter
       // ExtendedPatternCharacter ::
@@ -840,7 +846,9 @@
         bail('flags cannot be duplicated for modifiers group');
       }
 
-      skip(":");
+      if(!match(":")) {
+        bail('Invalid flags for modifiers group');
+      }
 
       var modifiersGroup = finishGroup("ignore", from);
 

diff --git a/test/test-data-modifiers-group.json b/test/test-data-modifiers-group.json
@@ -510,5 +510,29 @@
     "name": "SyntaxError",
     "message": "Invalid flags for modifiers group at position 9\n    ^[a-z](?-:[a-z])$\n             ^",
     "input": "^[a-z](?-:[a-z])$"
+  },
+  "^[a-z](?ui:[a-z])$": {
+    "type": "error",
+    "name": "SyntaxError",
+    "message": "Invalid flags for modifiers group at position 8\n    ^[a-z](?ui:[a-z])$\n            ^",
+    "input": "^[a-z](?ui:[a-z])$"
+  },
+  "^[a-z](?-ui:[a-z])$": {
+    "type": "error",
+    "name": "SyntaxError",
+    "message": "Invalid flags for modifiers group at position 9\n    ^[a-z](?-ui:[a-z])$\n             ^",
+    "input": "^[a-z](?-ui:[a-z])$"
+  },
+  "^[a-z](?iu:[a-z])$": {
+    "type": "error",
+    "name": "SyntaxError",
+    "message": "Invalid flags for modifiers group at position 9\n    ^[a-z](?iu:[a-z])$\n             ^",
+    "input": "^[a-z](?iu:[a-z])$"
+  },
+  "^[a-z](?-iu:[a-z])$": {
+    "type": "error",
+    "name": "SyntaxError",
+    "message": "Invalid flags for modifiers group at position 10\n    ^[a-z](?-iu:[a-z])$\n              ^",
+    "input": "^[a-z](?-iu:[a-z])$"
   }
 }