Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow filtering on null #82

Merged
merged 1 commit into from
Feb 13, 2016
Merged

Disallow filtering on null #82

merged 1 commit into from
Feb 13, 2016
+17 −5

Conversation

bkutil
Copy link
Contributor

@bkutil bkutil commented Feb 12, 2016

It is not consistently supported by influx DB

Fixes: #73

@bkutil
Copy link
Contributor Author

bkutil commented Feb 12, 2016

cc: @dmehra

@dmehra
Copy link
Contributor

dmehra commented Feb 12, 2016

let's add another test for "field != null". Also, let's get to green :)

Disallow filtering on null
20eed97 
It is not consistently supported by influx DB

Fixes: #73
@bkutil bkutil force-pushed the disallow-null-filter branch from 533012e to 20eed97 Compare February 12, 2016 13:10
@bkutil
Copy link
Contributor Author

bkutil commented Feb 12, 2016

Added the field != null test, and removed the offending one (testing for an error doesn't make sense on that level).

@dmehra
Copy link
Contributor

dmehra commented Feb 12, 2016

+1

bkutil added a commit that referenced this pull request Feb 13, 2016
@bkutil
Merge pull request #82 from juttle/disallow-null-filter
fa24182 
Disallow filtering on null
@bkutil bkutil merged commit fa24182 into master Feb 13, 2016
@bkutil bkutil deleted the disallow-null-filter branch February 13, 2016 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkutil @dmehra