Merge pull request #82 from juttle/disallow-null-filter

Disallow filtering on null

Author: bkutil

lib/ast/lint.js

@@ -68,6 +68,10 @@ class Linter extends ASTVisitor {
         this[`visit${node.type}`].apply(this, arguments);
     }
 
+    visitNullLiteral(node, options) {
+        throw new Error('Filtering null values is not supported');
+    }
+
     visitSimpleFilterTerm(node, options) {
         if (node.expression.type === 'StringLiteral') {
             throw new Error('Full text search is not supported');

test/ast/lint.spec.js

@@ -158,6 +158,19 @@ describe('query linting', () => {
         });
     });
 
+    it('doesnt allow null filters', () => {
+        var tests = [
+            'field != null',
+            'field = null',
+            'field1 = null or field2 = "1"',
+        ];
+
+        _.each(tests, (test) => {
+            var ast = utils.parseFilter(test);
+            expect(linter.lint.bind(linter, ast, { nameField: 'name' })).to.throw(/Filtering null values is not supported/);
+        });
+    });
+
     it('doesnt allow FTS filters', () => {
         var tests = [
             '"some string"',

test/query/query.spec.js

@@ -108,11 +108,6 @@ describe('influxql query building', () => {
                 expect(builder.build({ nameField: 'name' }, { filter_ast })).to.equal('SELECT * FROM /.*/ WHERE "key" = 1');
             });
 
-            it('simple filter null', () => {
-                var filter_ast = utils.parseFilter('key = null');
-                expect(builder.build({ nameField: 'name' }, { filter_ast })).to.equal('SELECT * FROM /.*/ WHERE "key" = null');
-            });
-
             it('implicit and', () => {
                 var filter_ast = utils.parseFilter('key1 = "val1" key2 = "val2"');
                 expect(builder.build({ nameField: 'name' }, { filter_ast })).to.equal('SELECT * FROM /.*/ WHERE "key1" = \'val1\' AND "key2" = \'val2\'');