Added viewpager2 in the favorites fragment, with 2 tabs #27
Conversation
There was a problem hiding this comment.
Hi @krishnachaitanya0107 I have reviewed this PR. Please make the required changes. Thanks.
app/src/main/java/divyansh/tech/animeclassroom/favorites/DynamicTabFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/divyansh/tech/animeclassroom/favorites/FavoritesFragment.kt
Show resolved
Hide resolved
app/src/main/java/divyansh/tech/animeclassroom/favorites/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/divyansh/tech/animeclassroom/favorites/FavoritesFragment.kt
Outdated
Show resolved
Hide resolved
|
@justdvnsh thank you for going through the code and suggesting improvements to the code , i have implemented these changes , please go through it and do let me know if there are any more things that can be improved . I will be happy to help . |
|
Looks Good to me @krishnachaitanya0107 Thank you so much for your contribution. If you'd like, please join the slack channel for further discussions (You can find the link in the readme). Thanks again. |
|
Thank you for accepting the pull request , it really means a lot to me . I would definitely love to join the slack channel . It felt really great working on this project and i would love to contribute and work on more issues on this project . Thank you for this wondeful opportunity . |
|
@krishnachaitanya0107 I am personally so happy to have contributors like you. best of luck for your open source journey. I am happy this project could have helped. |
|
@krishnachaitanya0107 also, I am going to launch another app in a few days. An open source app to download wallpapers for your phone. Without any ads. I would be happy if you'd contribute there as well. Moreover, this project is in heavy development, so new issues are being added everyday. Please contribute more to the project if you'd like. |
|
I will definitely check out that project and i will contribute to both the projects by resolving issues which i feel comfortable with . Thank you for helping me in my open source journey and for providing valuable feedback about my code to help improve my coding skills as well . |
Added viewpager2 in the favorites fragment, with 2 tabs .