Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ViewPager2 in the favorites Fragment #19

Closed
justdvnsh opened this issue Oct 4, 2021 · 7 comments
Closed

Add ViewPager2 in the favorites Fragment #19

justdvnsh opened this issue Oct 4, 2021 · 7 comments
Assignees
@krishnachaitanya0107
Labels
good first issue Good for newcomers hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed UI-change Label to put if there is any UI change

Comments

@justdvnsh
Copy link
Owner

We need a viewpager2 in the favorites fragment, with 2 tabs. One for the saved animes and one for the saved mangas.
@justdvnsh justdvnsh added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Issues to solve if participating in hacktoberfest UI-change Label to put if there is any UI change labels Oct 4, 2021
@krishnachaitanya0107
Copy link
Contributor

@justdvnsh , Hey , I wish to work on this issue . If this issue is still open , Can you please assign it to me .

@justdvnsh
Copy link
Owner Author

Hi @krishnachaitanya0107 Thanks for your interest. We are so happy to have you here. Please pull the latest commits before working on this issue. Also, please star the repo. It really helps a lot.

@krishnachaitanya0107
Copy link
Contributor

Thank You so much @justdvnsh for allowing me to work on this issue .
I have attempted to solve the issue and before sending a pull request could you please check out the implementation ( i have attached a screen recording of the implementation ) and please do let me know if there are any changes or improvements which can be done , I will be glad to implement them .

viewpager_impl.mp4

@justdvnsh
Copy link
Owner Author

@krishnachaitanya0107 It is perfectly fine. Thanks for your contribution. Please make a PR for this. Also, please don't forget to star the repo. It really helps. Thanks again

@krishnachaitanya0107
Copy link
Contributor

Thank You @justdvnsh for the quick response . I have already stared this amazing repo . It was great working on this issue . I am opening a pull request .

@justdvnsh
Copy link
Owner Author

@krishnachaitanya0107 go for it.

@justdvnsh
Copy link
Owner Author

Solved #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnachaitanya0107 krishnachaitanya0107

Labels
good first issue Good for newcomers hacktoberfest Issues to solve if participating in hacktoberfest help wanted Extra attention is needed UI-change Label to put if there is any UI change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justdvnsh @krishnachaitanya0107