Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target ES2018 #388

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Target ES2018 #388

merged 1 commit into from
Sep 4, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Sep 4, 2022

Fixes #387

@afshin afshin added maintenance Dependencies, build, technical debt, etc. performance Addresses performance labels Sep 4, 2022
@afshin afshin self-assigned this Sep 4, 2022
blink1073
blink1073 approved these changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 42d11c2 into jupyterlab:main Sep 4, 2022
This was referenced Sep 5, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees

@afshin afshin

Labels
maintenance Dependencies, build, technical debt, etc. performance Addresses performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we compile to ES2018 in Lumino 2?
2 participants
@afshin @blink1073