Merge pull request #388 from afshin/ES2018

jupyterlab · Sep 4, 2022 · 42d11c2 · 42d11c2
2 parents e24f3f0 + 447716b
commit 42d11c2
Show file tree

Hide file tree

Showing 37 changed files with 40 additions and 40 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -24,7 +24,7 @@ module.exports = {
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
-    ecmaVersion: 'ES6',
+    ecmaVersion: 'ES2018',
     project: ['./tsconfigbase.json']
   },
   plugins: ['@typescript-eslint'],

diff --git a/docs/source/migration.md b/docs/source/migration.md
@@ -14,7 +14,7 @@ All invocations of `each(...)` have been removed in Lumino 2. See, for example,
 
 ### Use `[].forEach(...)` sparingly
 
-Now that we support native ES6 iteration, `for (const value of someArray) {...}` should be favored over `someArray.forEach(...)` because it will not require a context shift every time it invokes the function being applied.
+Now that we support native ES2018 iteration, `for (const value of someArray) {...}` should be favored over `someArray.forEach(...)` because it will not require a context shift every time it invokes the function being applied.
 
 ### Use `[Symbol.iterator]()` sparingly
 

diff --git a/examples/example-accordionpanel/tsconfig.json b/examples/example-accordionpanel/tsconfig.json
@@ -8,9 +8,9 @@
     "sourceMap": true,
     "module": "commonjs",
     "moduleResolution": "node",
-    "target": "ES6",
+    "target": "ES2018",
     "outDir": "./build",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "types": []
   },
   "include": ["src/*"]

diff --git a/examples/example-datagrid/tsconfig.json b/examples/example-datagrid/tsconfig.json
@@ -7,9 +7,9 @@
     "strictNullChecks": true,
     "module": "commonjs",
     "moduleResolution": "node",
-    "target": "ES6",
+    "target": "ES2018",
     "outDir": "./build",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "types": []
   },
   "include": ["src/*"]

diff --git a/examples/example-dockpanel/tsconfig.json b/examples/example-dockpanel/tsconfig.json
@@ -8,9 +8,9 @@
     "sourceMap": true,
     "module": "commonjs",
     "moduleResolution": "node",
-    "target": "ES6",
+    "target": "ES2018",
     "outDir": "./build",
-    "lib": ["ES6", "DOM"],
+    "lib": ["DOM", "ES2018"],
     "types": []
   },
   "include": ["src/*"]

diff --git a/packages/algorithm/tests/tsconfig.json b/packages/algorithm/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/algorithm/tsconfig.json b/packages/algorithm/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/application/tests/tsconfig.json b/packages/application/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/application/tsconfig.json b/packages/application/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/collections/tests/tsconfig.json b/packages/collections/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/collections/tsconfig.json b/packages/collections/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/commands/tests/tsconfig.json b/packages/commands/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/commands/tsconfig.json b/packages/commands/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/coreutils/tests/tsconfig.json b/packages/coreutils/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/coreutils/tsconfig.json b/packages/coreutils/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/datagrid/tsconfig.json b/packages/datagrid/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/disposable/tests/tsconfig.json b/packages/disposable/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/disposable/tsconfig.json b/packages/disposable/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/domutils/tests/tsconfig.json b/packages/domutils/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/domutils/tsconfig.json b/packages/domutils/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/dragdrop/tests/tsconfig.json b/packages/dragdrop/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/dragdrop/tsconfig.json b/packages/dragdrop/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/keyboard/tests/tsconfig.json b/packages/keyboard/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/keyboard/tsconfig.json b/packages/keyboard/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/messaging/tests/tsconfig.json b/packages/messaging/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha", "@types/node"]

diff --git a/packages/messaging/tsconfig.json b/packages/messaging/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["@types/node"]

diff --git a/packages/polling/README.md b/packages/polling/README.md
@@ -120,4 +120,4 @@ expect(ticker.join(' ')).to.equal(expected);
 
 ### Note for consumers of async iterators
 
-The `Poll` class itself only uses `ES6` (and `DOM`) types in its `lib` collection **but** in order to use `for-await...of` loops in TypeScript, you will need to use `ES2018` or above in your `lib` array in `tsconfig.json`.
+In order to use `for-await...of` loops in TypeScript, you will need to use `ES2018` or above in your `lib` array in `tsconfig.json`.
diff --git a/packages/polling/tsconfig.json b/packages/polling/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["@types/node"]

diff --git a/packages/properties/tests/tsconfig.json b/packages/properties/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/properties/tsconfig.json b/packages/properties/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["ES6"],
+    "lib": ["ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/signaling/tests/tsconfig.json b/packages/signaling/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/signaling/tsconfig.json b/packages/signaling/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["@types/node"]

diff --git a/packages/virtualdom/tests/tsconfig.json b/packages/virtualdom/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/virtualdom/tsconfig.json b/packages/virtualdom/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/packages/widgets/tests/tsconfig.json b/packages/widgets/tests/tsconfig.json
@@ -1,7 +1,7 @@
 {
   "extends": "../../../tsconfigbase",
   "compilerOptions": {
-    "lib": ["DOM", "ES6"],
+    "lib": ["DOM", "ES2018"],
     "outDir": "lib",
     "rootDir": "src",
     "types": ["chai", "mocha"]

diff --git a/packages/widgets/tsconfig.json b/packages/widgets/tsconfig.json
@@ -2,7 +2,7 @@
   "extends": "../../tsconfigbase",
   "compilerOptions": {
     "declarationDir": "types",
-    "lib": ["DOM", "DOM.Iterable", "ES6"],
+    "lib": ["DOM", "DOM.Iterable", "ES2018"],
     "outDir": "lib",
     "rootDir": "src"
   },

diff --git a/tsconfigbase.json b/tsconfigbase.json
@@ -18,7 +18,7 @@
     "resolveJsonModule": true,
     "sourceMap": true,
     "strictNullChecks": true,
-    "target": "ES6",
+    "target": "ES2018",
     "types": []
   }
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -120,4 +120,4 @@ expect(ticker.join(' ')).to.equal(expected);

		### Note for consumers of async iterators

		The `Poll` class itself only uses `ES6` (and `DOM`) types in its `lib` collection but in order to use `for-await...of` loops in TypeScript, you will need to use `ES2018` or above in your `lib` array in `tsconfig.json`.
		In order to use `for-await...of` loops in TypeScript, you will need to use `ES2018` or above in your `lib` array in `tsconfig.json`.